On Mon, 21 Jul 2025 at 21:11, <fanyi...@rt-thread.org> wrote: > > From: Yihao Fan <fanyi...@rt-thread.org> > > This patch introduces a new QEMU machine type for the STM32F407 SoC featuring > a Cortex-M4 core. > This will be used by the RT-Spark to create a machine.
The Subject line of this patch seems to have hyphens instead of spaces. A "hw/arm:" prefix would also be helpful. > diff --git a/hw/arm/stm32f407_soc.c b/hw/arm/stm32f407_soc.c > new file mode 100644 > index 0000000000..0a91d4bb10 > --- /dev/null > +++ b/hw/arm/stm32f407_soc.c > @@ -0,0 +1,130 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ This seems very similar to the existing stm32f05_soc.c. How different are these two SoCs? Would it make sense to share code? I've cc'd Alistair as the maintainer of the stm32f05. thanks -- PMM
