On Fri, 8 Aug 2025 at 07:54, Mohamed Mediouni <moha...@unpredictable.fr> wrote: > > On Hypervisor.framework for macOS and WHPX for Windows, the provided > environment is a GICv3 without ITS. > > As such, support a GICv3 w/ GICv2m for that scenario. > > Signed-off-by: Mohamed Mediouni <moha...@unpredictable.fr> > > Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
This breaks the bios-tables-test which is run as part of "make check", because the ACPI tables generated no longer match the golden reference output. If the ACPI table change here is intentional then the comment at the top of tests/qtest/bios-tables-test.c describes the process and sequence of patches you need to update the reference versions. $ make -C build/arm-clang/ -j6 && (cd build/arm-clang/ && QTEST_QEMU_BINARY=./qemu-system-aarch64 ./tests/qtest/bios-tables-test) make: Entering directory '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang' [1/28] Generating qemu-version.h with a custom command (wrapped by meson to capture output) [2/8] Compiling C object libsystem.a.p/hw_pci-host_gpex-acpi.c.o [3/8] Compiling C object libqemu-arm-softmmu.a.p/hw_arm_virt-acpi-build.c.o [4/8] Compiling C object libqemu-aarch64-softmmu.a.p/hw_arm_virt-acpi-build.c.o [5/8] Compiling C object libqemu-arm-softmmu.a.p/hw_arm_virt.c.o [6/8] Compiling C object libqemu-aarch64-softmmu.a.p/hw_arm_virt.c.o [7/8] Linking target qemu-system-arm [8/8] Linking target qemu-system-aarch64 make: Leaving directory '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang' TAP version 13 # random seed: R02Sbd44a41112c6e2df4635231a2a1f3510 # starting QEMU: exec ./qemu-system-aarch64 -qtest unix:/tmp/qtest-2147871.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-2147871.qmp,id=char0 -mon chardev=char0,mode=control -display none -audio none -machine none -accel qtest # starting QEMU: exec ./qemu-system-aarch64 -qtest unix:/tmp/qtest-2147871.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-2147871.qmp,id=char0 -mon chardev=char0,mode=control -display none -audio none -machine none -accel qtest 1..12 # Start of aarch64 tests # Start of acpi tests # starting QEMU: exec ./qemu-system-aarch64 -qtest unix:/tmp/qtest-2147871.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-2147871.qmp,id=char0 -mon chardev=char0,mode=control -display none -audio none -machine virt -accel tcg -nodefaults -nographic -drive if=pflash,format=raw,file=pc-bios/edk2-aarch64-code.fd,readonly=on -drive if=pflash,format=raw,file=pc-bios/edk2-arm-vars.fd,snapshot=on -cdrom tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2 -cpu cortex-a57 -machine ras=on -smbios type=4,max-speed=2900,current-speed=2700 -accel qtest acpi-test: Warning! APIC binary file mismatch. Actual [aml:/tmp/aml-0EHGB3], Expected [aml:tests/data/acpi/aarch64/virt/APIC]. See source file tests/qtest/bios-tables-test.c for instructions on how to update expected files. acpi-test: Warning! APIC mismatch. Actual [asl:/tmp/asl-48FGB3.dsl, aml:/tmp/aml-0EHGB3], Expected [asl:/tmp/asl-D5NHB3.dsl, aml:tests/data/acpi/aarch64/virt/APIC]. ** ERROR:../../tests/qtest/bios-tables-test.c:554:test_acpi_asl: assertion failed: (all_tables_match) not ok /aarch64/acpi/virt - ERROR:../../tests/qtest/bios-tables-test.c:554:test_acpi_asl: assertion failed: (all_tables_match) Bail out! Aborted (core dumped) thanks -- PMM
