Arun Menon <arme...@redhat.com> writes: > The post_save() function call is responsible for cleaning up resources > after the device state has been saved. > Currently it is infallible, and does not return an error. > > It is called regardless of whether there is a preceding error from > save or subsection save. That is, save and post_save() together are > considered to be an atomic logical operation. > > It should not be confused as a counterpart of the post_load() function > because post_load() does some sanity checks and returns an error if it > fails. This commit, therefore, renames post_save() to cleanup_save() > and makes it a void function. > > Signed-off-by: Arun Menon <arme...@redhat.com>
Reviewed-by: Fabiano Rosas <faro...@suse.de> However, the change feels a bit superfluous, so I would have pushed back on it. But I see it comes from previous discussion at: https://lore.kernel.org/r/fa7bcb8f-03c1-4528-ae67-b7b8c5d6f...@rsg.ci.i.u-tokyo.ac.jp In these cases it's useful to add a: Suggested-by: Akihiko Odaki <od...@rsg.ci.i.u-tokyo.ac.jp> so it's clear another reviewer already pondered about this.
