Re: [PATCH 1/4] target/ppc: Add IBM PPE42 family of processors

[Harsh Prateek Bora]

On 8/25/25 22:26, Miles Glenn wrote:

@@ -186,6 +186,10 @@ static uint32_t hreg_compute_hflags_value(CPUPPCState *env)
       if (env->spr[SPR_LPCR] & LPCR_HR) {
           hflags |= 1 << HFLAGS_HR;
       }
+    if (ppc_flags & POWERPC_FLAG_PPE42) {
+        /* PPE42 has a single address space and no problem state */
+        msr = 0;
+    }

We really dont want this to be checked on PPC64 machines, hence
!TARGET_PPC64 needed.

This is related to the issue of whether we want to continue supporting
32-bit CPUs inside the 64-bit executable.  It seems that the community
is saying that we should continue to do that, so I'd like to keep this
in even for PPC64 machines, but I will go ahead and add an 'unlikely'
here in order to possibly lessen the impact.

Yeh, sure, that should suffice for now.

Thanks
Harsh