On Wed, Jul 23, 2025 at 03:32:57PM +0200, Markus Armbruster wrote: > Date: Wed, 23 Jul 2025 15:32:57 +0200 > From: Markus Armbruster <arm...@redhat.com> > Subject: [PATCH 2/2] vfio scsi ui: Error-check > qio_channel_socket_connect_sync() the same way > > qio_channel_socket_connect_sync() returns 0 on success, and -1 on > failure, with errp set. Some callers check the return value, and some > check whether errp was set. > > For consistency, always check the return value, and always check it's > negative. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/vfio-user/proxy.c | 2 +- > scsi/pr-manager-helper.c | 9 ++------- > ui/input-barrier.c | 5 +---- > 3 files changed, 4 insertions(+), 12 deletions(-)
Reviewed-by: Zhao Liu <zhao1....@intel.com>