On Thu, Sep 28, 2017 at 12:59:56PM -0500, Eric Blake wrote: > On 09/28/2017 07:06 AM, Daniel P. Berrange wrote: > > Currently if DTC is required by configure and not available in the host > > OS install, we exit with an error message telling the user to checkout a > > git submodule or install the library. > > > > This introduces automatic handling of the git submodule checkout process > > and enables it for dtc. This only runs if building from GIT, so users of > > release tarballs still need the system library install. The current state > > of the git checkout is stashed in .git-submodule-status, and a helper > > program is used to determine if this state matches the desired submodule > > state. A dependency against 'Makefile' ensures that the submodule state > > is refreshed at the start of the build process > > > > > +++ b/scripts/git-submodule.sh > > @@ -0,0 +1,31 @@ > > +#!/bin/bash > > + > > +set -e > > New file, but appears not to be covered by MAINTAINERS; that should be > fixed. Also, an explicit copyright/license might be needed.
Yes to both. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
