Fabiano Rosas <faro...@suse.de> writes: > Signed-off-by: Fabiano Rosas <faro...@suse.de> > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > --- > qapi/migration.json | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index c352c7ac52..abebe23523 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -1519,10 +1519,25 @@ > # > # @rdma: Migrate via RDMA. > # > +# @file: Direct the migration stream to a file. > +# > # Since 8.2 > ## > { 'enum': 'MigrationAddressType', > - 'data': ['socket', 'exec', 'rdma'] } > + 'data': [ 'socket', 'exec', 'rdma', 'file' ] } > + > +## > +# @FileMigrationArgs: > +# > +# @filename: The file to receive the migration stream > +# > +# @offset: The file offset where the migration stream will start > +# > +# Since 8.2 > +## > +{ 'struct': 'FileMigrationArgs', > + 'data': { 'filename': 'str', > + 'offset': 'uint64' } }
Have you considered making @offset optional, default 0? This is *not* a demand! > > ## > # @MigrationExecCommand: > @@ -1547,7 +1562,8 @@ > 'data': { > 'socket': 'SocketAddress', > 'exec': 'MigrationExecCommand', > - 'rdma': 'InetSocketAddress' } } > + 'rdma': 'InetSocketAddress', > + 'file': 'FileMigrationArgs' } } > > ## > # @migrate: Acked-by: Markus Armbruster <arm...@redhat.com>