On Tue, 2023-10-24 at 10:15 +1030, Andrew Jeffery wrote: > On Fri, 2023-10-20 at 13:23 -0500, Glenn Miles wrote: > > The pca9552 INPUT0 and INPUT1 registers are supposed to > > hold the logical values of the LED pins. A logical 0 > > should be seen in the INPUT0/1 registers for a pin when > > its corresponding LSn bits are set to 0, which is also > > the state needed for turning on an LED in a typical > > usage scenario. Existing code was doing the opposite > > and setting INPUT0/1 bit to a 1 when the LSn bit was > > set to 0, so this commit fixes that. > > > > Signed-off-by: Glenn Miles <mil...@linux.vnet.ibm.com> > > I sent a Reviewed-by tag for v1, don't forget to collect those on > your > patches before sending out a new set. Something for next time :) > > Anyway, > > Reviewed-by: Andrew Jeffery <and...@codeconstruct.com.au> >
Yeah, of course I realized that I forgot that after sending it! :-) Glenn
