Hello! Is there any progress on this patch?
________________________________
От: Marc-André Lureau <marcandre.lur...@redhat.com>
Отправлено: 16 октября 2023 г. 15:23:42
Кому: Миронов Сергей Владимирович
Копия: kra...@redhat.com; qemu-devel@nongnu.org; Linux Verification Center
Тема: Re: [PATCH 1/1] ui: Replacing pointer in function
On Thu, Oct 12, 2023 at 2:46 PM Sergey Mironov <miro...@fintech.ru> wrote:
>
> At the end of the first if we see 'vc->gfx.surface = NULL;',
> further checking of it is pointless. In the second if, ectx is taken.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Co-developed-by: Linux Verification Center <sdl.q...@linuxtesting.org>
> Signed-off-by: Sergey Mironov <miro...@fintech.ru>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 935de1209b..5da3f9b022 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -1400,7 +1400,7 @@ static void gd_menu_untabify(GtkMenuItem *item, void
> *opaque)
> eglDestroySurface(qemu_egl_display, vc->gfx.esurface);
> vc->gfx.esurface = NULL;
> }
> - if (vc->gfx.esurface) {
> + if (vc->gfx.ectx) {
> eglDestroyContext(qemu_egl_display, vc->gfx.ectx);
> vc->gfx.ectx = NULL;
> }
> --
> 2.31.1
>
