On Tue, 7 Nov 2023 at 09:10, BALATON Zoltan <bala...@eik.bme.hu> wrote: > > On Tue, 7 Nov 2023, Stefan Hajnoczi wrote: > > On Mon, 6 Nov 2023 at 19:04, BALATON Zoltan <bala...@eik.bme.hu> wrote: > >> > >> On Mon, 6 Nov 2023, Marc-André Lureau wrote: > >>> Hi Zoltan > >>> > >>> On Mon, Nov 6, 2023 at 2:53 PM BALATON Zoltan <bala...@eik.bme.hu> wrote: > >>>> > >>>> On Mon, 6 Nov 2023, Philippe Mathieu-Daudé wrote: > >>>>> On 6/11/23 11:11, Marc-André Lureau wrote: > >>>>>> Hi Philippe > >>>>>> > >>>>>> On Mon, Nov 6, 2023 at 2:03 PM Philippe Mathieu-Daudé > >>>>>> <phi...@linaro.org> > >>>>>> wrote: > >>>>>>> > >>>>>>> Hi Marc-André, > >>>>>>> > >>>>>>> Cc'ing Fuloong maintainers, > >>>>>>> > >>>>>>> On 6/11/23 10:55, marcandre.lur...@redhat.com wrote: > >>>>>>>> From: Marc-André Lureau <marcandre.lur...@redhat.com> > >>>>>>>> > >>>>>>>> To avoid a kconfig cycle, change "depends on PCI" to "select PCI". > >>>>>>>> > >>>>>>>> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > >>>>>>>> Acked-by: BALATON Zoltan <bala...@eik.bme.hu> > >>>>>>>> --- > >>>>>>>> configs/devices/mips64el-softmmu/default.mak | 3 +-- > >>>>>>>> hw/display/Kconfig | 3 ++- > >>>>>>>> hw/display/meson.build | 2 +- > >>>>>>>> hw/mips/Kconfig | 2 ++ > >>>>>>>> 4 files changed, 6 insertions(+), 4 deletions(-) > >>>>>>>> > >>>>>>>> diff --git a/configs/devices/mips64el-softmmu/default.mak > >>>>>>>> b/configs/devices/mips64el-softmmu/default.mak > >>>>>>>> index d5188f7ea5..4d80d60511 100644 > >>>>>>>> --- a/configs/devices/mips64el-softmmu/default.mak > >>>>>>>> +++ b/configs/devices/mips64el-softmmu/default.mak > >>>>>>>> @@ -1,9 +1,8 @@ > >>>>>>>> # Default configuration for mips64el-softmmu > >>>>>>>> > >>>>>>>> include ../mips-softmmu/common.mak > >>>>>>>> -CONFIG_FULOONG=y > >>>>>>>> +#CONFIG_FULOONG=y > >>>>>>> > >>>>>>> Why is the justification to disable this board? From the > >>>>>>> bare "avoid a kconfig cycle" commit message, it is not > >>>>>>> obvious to me. > >>>>>> > >>>>>> It's not actually disabled, it's enabled by default in kconfig. > >>>>> > >>>>> OK, so let's remove the line entirely, not comment it, please. > >>>> > >>>> Well it's disabled without pixman... I have a series adding fallbacks to > >>>> ati-vga similar to sm501 (which is also needed on aarch64 macOS where > >>>> pixman does not work) and with that this isn't needed. So I think it's > >>>> better to rebase this series on mine then some of this becomes > >>>> unnecessary. > >>>> > >>> > >>> > >>> It's not ready yet though. We can later revert some of this change > >> > >> What's not ready about it? > >> > >>> when your fallback version is applied. In the meantime, this doesn't > >>> change the behaviour unless PIXMAN has been disabled, so it should be > >>> acceptable. Agree? thanks > >> > >> I think it would be better to not commit something that should be reverted > >> soon. I understand you don't want to rebase yout series but I also don't > >> want to revert it later so either do the rebase now or hold off with this > >> series until after mine got in please. > > > > QEMU 8.2 soft freeze is today. If you both can resolve this and send > > pull requests today, then the changes will make it into 8.2. > > Otherwise, asking for this pull request to be rebased has the effect > > of delaying it until 8.3. > > > > I'll keep an eye on this series today. > > Marc-André has sent a pull request that contains my ati-vga series: > https://patchew.org/QEMU/20231106133219.2173660-1-marcandre.lur...@redhat.com/ > so I think he intends to rebase this series and send another version today > or come back to this later. (8.3 will be called 9.0 by the way).
Excellent, thanks! Stefan
