Hi
On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank <fran...@linux.ibm.com> wrote:
>
> Better to not rely on the struct zeroing since NULL is not necessarily
> 0.
>
> Signed-off-by: Janosch Frank <fran...@linux.ibm.com>
> ---
> dump/dump.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/dump/dump.c b/dump/dump.c
> index d355ada62e..1d38274925 100644
> --- a/dump/dump.c
> +++ b/dump/dump.c
> @@ -1706,6 +1706,9 @@ static void dump_state_prepare(DumpState *s)
> {
> /* zero the struct, setting status to active */
> *s = (DumpState) { .status = DUMP_STATUS_ACTIVE };
> + s->dump_info.arch_sections_add_fn = NULL;
> + s->dump_info.arch_sections_write_hdr_fn = NULL;
> + s->dump_info.arch_sections_write_fn = NULL;
> }
I think we would be in trouble if NULL is not 0. Do you have a better argument?
--
Marc-André Lureau
