On Mon, Nov 13, 2023 at 11:40:18AM +0000, Alex Bennée wrote:
> Thomas Huth <th...@redhat.com> writes:
>
> > On 03/07/2023 15.44, Alex Bennée wrote:
> >> The old g_memdup is deprecated, use the replacement.
> >> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> >> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
> >> Message-Id: <20230630180423.558337-22-alex.ben...@linaro.org>
> >> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> >> index e36f0b9562..3614c3564c 100644
> >> --- a/contrib/plugins/lockstep.c
> >> +++ b/contrib/plugins/lockstep.c
> >> @@ -130,7 +130,7 @@ static void report_divergance(ExecState *us, ExecState
> >> *them)
> >> }
> >> }
> >> divergence_log = g_slist_prepend(divergence_log,
> >> - g_memdup(&divrec, sizeof(divrec)));
> >> + g_memdup2(&divrec, sizeof(divrec)));
> >> /* Output short log entry of going out of sync... */
> >> if (verbose || divrec.distance == 1 || diverged) {
> >
> > FYI, this seems to trigger a compiler warning on Ubuntu 20.04:
> >
> > https://app.travis-ci.com/github/huth/qemu/jobs/613144955#L1914
>
> Isn't 20.04 outside of our support range now? Otherwise we could add a
> helper to glib-compat.
We're still in the 2 year overlap since 22.04 was released, so 20.04 will
remain a target until April next year.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
