... did you shamelessly copy that from hw/virtio/virtio-mem.c ? ;)

Get caught.

This should be factored out into a common helper.

Sure, will do it in next version.

Factor it out in a separate patch. Then, this patch is get small that you can just squash it into #2.

And my comment regarding "flags = 0" to patch #2 does no longer apply :)

--
Cheers,

David / dhildenb


Reply via email to