On 11/20/23 07:08, Alex Bennée wrote:
+/*
+ * Helper macro for the linker calling subroutines from the C code.
+ */

That's not all it's for.  Better "annotating functions with elf type and size".

+vector_table:
+       b   reset               /* reset vector */
+       b   undef_instr        /* undefined instruction vector */
+       b   software_intr       /* software interrupt vector */
+       b   prefetch_abort              /* prefetch abort vector */
+       b   data_abort          /* data abort vector */
+       nop                                 /* reserved */
+       b   IRQ_handler         /* IRQ vector */
+       b   FIQ_handler         /* FIQ vector */

Missing endf, for the purpose of qemu load_symbols().

+mmu_setup:
+reset:
+undef_instr:
+software_intr:
+prefetch_abort:
+data_abort:
+IRQ_handler:
+FIQ_handler:

Also missing.

With those fixed,

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~

Reply via email to