Well, this requeuing bug seems to have a long breath. Previous attempts to fix it (mine included) neglected the fact that we need to walk the queue of pending packets, not just restart from the beginning after a requeue. This version should get it Right(TM).
This also comes with a fix for resource cleanups on slirp shutdown. At least valgrind is happy now. Changes in v3: - Finally fixed Stefan's scenario by avoiding the recursion of if_start - Fixed further corner cases in walking the packet queues CC: Fabien Chouteau <chout...@adacore.com> CC: Michael S. Tsirkin <m...@redhat.com> CC: Stefan Weil <s...@weilnetz.de> CC: Zhi Yong Wu <wu...@linux.vnet.ibm.com> Jan Kiszka (5): slirp: Keep next_m always valid slirp: Prevent recursion of if_start slirp: Fix queue walking in if_start slirp: Remove unneeded if_queued slirp: Cleanup resources on instance removal slirp/if.c | 86 ++++++++++++++++++++++++++++++++++------------------- slirp/ip_icmp.c | 7 ++++ slirp/ip_icmp.h | 1 + slirp/ip_input.c | 7 ++++ slirp/mbuf.c | 21 +++++++++++++ slirp/mbuf.h | 1 + slirp/slirp.c | 10 ++---- slirp/slirp.h | 4 ++- slirp/tcp_subr.c | 7 ++++ slirp/udp.c | 8 +++++ slirp/udp.h | 1 + 11 files changed, 115 insertions(+), 38 deletions(-) -- 1.7.3.4
