On 11/22/23 12:13, Philippe Mathieu-Daudé wrote:
Hi Harsh,

On 22/11/23 10:28, Harsh Prateek Bora wrote:
spapr_irq_init currently uses existing macro SPAPR_XIRQ_BASE to refer to
the range of CPU IPIs during initialization of nr-irqs property.
It is more appropriate to have its own define which can be further
reused as appropriate for correct interpretation.

Signed-off-by: Harsh Prateek Bora <hars...@linux.ibm.com>
Suggested-by: Cedric Le Goater <c...@kaod.org>
---
  hw/ppc/spapr_irq.c         | 4 ++--
  include/hw/ppc/spapr_irq.h | 1 +
  2 files changed, 3 insertions(+), 2 deletions(-)


diff --git a/include/hw/ppc/spapr_irq.h b/include/hw/ppc/spapr_irq.h
index c22a72c9e2..e7a80a8349 100644
--- a/include/hw/ppc/spapr_irq.h
+++ b/include/hw/ppc/spapr_irq.h
@@ -28,6 +28,7 @@
  #define SPAPR_IRQ_MSI        (SPAPR_XIRQ_BASE + 0x0300)
  #define SPAPR_NR_XIRQS       0x1000
+#define SPAPR_NR_IPIS        0x1000

BTW why hexadecimal and not decimal?

I think because the HW IRQs are displayed in hex under Linux. Probably.
It has been a while.

Thanks,

C.



Reply via email to