On 1/24/24 17:56, Philippe Mathieu-Daudé wrote:
From: Ilya Leoshkevich <i...@linux.ibm.com>

tcg/ should not depend on accel/tcg/, but perf and debuginfo
support provided by the latter are being used by tcg/tcg.c.

Since that's the only user, move both to tcg/.

Suggested-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Signed-off-by: Ilya Leoshkevich <i...@linux.ibm.com>
Message-ID: <20231208003754.3688038-5-...@linux.ibm.com>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  {accel/tcg => tcg}/debuginfo.h | 4 ++--
  {accel/tcg => tcg}/perf.h      | 4 ++--

Headers should be in include/tcg/.

--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -63,7 +63,7 @@
  #include "tb-context.h"
  #include "internal-common.h"
  #include "internal-target.h"
-#include "perf.h"
+#include "tcg/perf.h"

Since it is used from accel/tcg/,

  #include "tcg/insn-start-words.h"
TBContext tb_ctx;
diff --git a/hw/core/loader.c b/hw/core/loader.c
index e7a9b3775b..b8e52f3fb0 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -62,7 +62,7 @@
  #include "hw/boards.h"
  #include "qemu/cutils.h"
  #include "sysemu/runstate.h"
-#include "accel/tcg/debuginfo.h"
+#include "tcg/debuginfo.h"

... and hw/core/.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~

Reply via email to