On Sun, Feb 4, 2024 at 9:00 PM Bernhard Beschow <shen...@gmail.com> wrote:
> >-/* SMS FDC37M817 Super I/O */
> >-static void fdc37m81x_class_init(ObjectClass *klass, void *data)
> >-{
> >- ISASuperIOClass *sc = ISA_SUPERIO_CLASS(klass);
> >-
> >- sc->serial.count = 2; /* NS16C550A */
> >- sc->parallel.count = 1;
> >- sc->floppy.count = 1; /* SMSC 82077AA Compatible */
>
> >- sc->ide.count = 0;
>
> Isn't this assignment redundant?
I think it's there for clarity.
> >+config FDC37M81X
> >+ bool
>
> + select ISA_SUPERIO
> (in alphabetical order)
>
> >+ select ISA_BUS
>
> Shouldn't it `depend on ISA_BUS`?
It should be there in "config ISA_SUPERIO". That was a mistake in the
original patch that introduced hw/isa/Kconfig. And VT82C686 should
also select ISA_BUS because it's a combined PCI-ISA bridge and SuperIO
chip.
Paolo
> >+ select IDE_ISA
>
> Not needed. This device doesn't have an IDE interface.
>
> Best regards,
> Bernhard
>
> >+
> > config PC87312
> > bool
> > select ISA_SUPERIO
> >diff --git a/hw/isa/meson.build b/hw/isa/meson.build
> >index 2ab99ce0c6b..f650b395071 100644
> >--- a/hw/isa/meson.build
> >+++ b/hw/isa/meson.build
> >@@ -4,6 +4,7 @@ system_ss.add(when: 'CONFIG_ISA_BUS', if_true:
> >files('isa-bus.c'))
> > system_ss.add(when: 'CONFIG_ISA_SUPERIO', if_true: files('isa-superio.c'))
> > system_ss.add(when: 'CONFIG_PC87312', if_true: files('pc87312.c'))
> > system_ss.add(when: 'CONFIG_PIIX', if_true: files('piix.c'))
> >+system_ss.add(when: 'CONFIG_FDC37M81X', if_true:
> >files('fdc37m81x-superio.c'))
> > system_ss.add(when: 'CONFIG_SMC37C669', if_true:
> > files('smc37c669-superio.c'))
> > system_ss.add(when: 'CONFIG_VT82C686', if_true: files('vt82c686.c'))
> >
> >diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
> >index ab61af209a0..94b969c21db 100644
> >--- a/hw/mips/Kconfig
> >+++ b/hw/mips/Kconfig
> >@@ -1,7 +1,7 @@
> > config MALTA
> > bool
> >+ select FDC37M81X
> > select GT64120
> >- select ISA_SUPERIO
> > select PIIX
> >
> > config MIPSSIM
>
