On 12/02/2024 13:56, Joao Martins wrote: > diff --git a/backends/iommufd.c b/backends/iommufd.c > index 8486894f1b3f..2970135af4b9 100644 > --- a/backends/iommufd.c > +++ b/backends/iommufd.c > @@ -211,6 +211,35 @@ int iommufd_backend_unmap_dma(IOMMUFDBackend *be, > uint32_t ioas_id, > return ret; > } > > +int iommufd_backend_alloc_hwpt(int iommufd, uint32_t dev_id, > + uint32_t pt_id, uint32_t flags, > + uint32_t data_type, uint32_t data_len, > + void *data_ptr, uint32_t *out_hwpt)
This function looks to be against the style of the file. Which is to have IOMMUFDBackend as an argument rather than passing the file descriptor directly. Likewise for dev_id now that we have IOMMUFDDevice structure. I've fixed that for the next version (whether or not we require Zhengzhong series). Joao