On Fri, Feb 16, 2024 at 03:58:25PM +0100, Markus Armbruster wrote:
> The test compares Sphinx plain-text output against a golden reference.
> To work on Windows hosts, it filters out carriage returns in both
> files.  Unfortunately, the filter doesn't work: it creates an empty
> file.  Comparing empty files always succeeds.

lol, opps :)

> 
> Fix the filter, and update the golden reference to current Sphinx
> output.
> 
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
>  tests/qapi-schema/doc-good.txt | 21 +++++++++------------
>  tests/qapi-schema/meson.build  | 10 ++++++----
>  2 files changed, 15 insertions(+), 16 deletions(-)

Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Reply via email to