On Fri, Feb 23, 2024 at 04:16:53PM +0900, Wonjae Lee wrote: > On 2024-02-22 오전 3:16, nifan....@gmail.com wrote: > > From: Fan Ni <fan...@samsung.com> > > > > Add dynamic capacity extent list representative to the definition of > > CXLType3Dev and add get DC extent list mailbox command per > > CXL.spec.3.1:.8.2.9.9.9.2. > > > > Signed-off-by: Fan Ni <fan...@samsung.com> > > --- > > hw/cxl/cxl-mailbox-utils.c | 71 +++++++++++++++++++++++++++++++++++++ > > hw/mem/cxl_type3.c | 1 + > > include/hw/cxl/cxl_device.h | 23 ++++++++++++ > > 3 files changed, 95 insertions(+) > > > > diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c > > index f95e417683..dae7fe00ed 100644 > > --- a/hw/cxl/cxl-mailbox-utils.c > > +++ b/hw/cxl/cxl-mailbox-utils.c > > @@ -83,6 +83,7 @@ enum { > > #define CLEAR_POISON 0x2 > > DCD_CONFIG = 0x48, > > #define GET_DC_CONFIG 0x0 > > + #define GET_DYN_CAP_EXT_LIST 0x1 > > PHYSICAL_SWITCH = 0x51, > > #define IDENTIFY_SWITCH_DEVICE 0x0 > > #define GET_PHYSICAL_PORT_STATE 0x1 > > @@ -1344,6 +1345,73 @@ static CXLRetCode cmd_dcd_get_dyn_cap_config(const > > struct cxl_cmd *cmd, > > return CXL_MBOX_SUCCESS; > > } > > +/* > > + * CXL r3.1 section 8.2.9.9.9.2: > > + * Get Dynamic Capacity Extent List (Opcode 4801h) > > + */ > > +static CXLRetCode cmd_dcd_get_dyn_cap_ext_list(const struct cxl_cmd *cmd, > > + uint8_t *payload_in, > > + size_t len_in, > > + uint8_t *payload_out, > > + size_t *len_out, > > + CXLCCI *cci) > > +{ > > + CXLType3Dev *ct3d = CXL_TYPE3(cci->d); > > + struct get_dyn_cap_ext_list_in_pl { > > + uint32_t extent_cnt; > > + uint32_t start_extent_id; > > + } QEMU_PACKED; > > + > > + struct get_dyn_cap_ext_list_out_pl { > > + uint32_t count; > > + uint32_t total_extents; > > + uint32_t generation_num; > > + uint8_t rsvd[4]; > > + CXLDCExtentRaw records[]; > > + } QEMU_PACKED; > > + > > + struct get_dyn_cap_ext_list_in_pl *in = (void *)payload_in; > > + struct get_dyn_cap_ext_list_out_pl *out = (void *)payload_out; > > + uint16_t record_count = 0, i = 0, record_done = 0; > > + CXLDCExtentList *extent_list = &ct3d->dc.extents; > > + CXLDCExtent *ent; > > + uint16_t out_pl_len; > > + uint32_t start_extent_id = in->start_extent_id; > > + > > + if (start_extent_id > ct3d->dc.total_extent_count) { > > Hello, > > Shouldn't it be >= rather than >? > > (I accidentally replied to v3 with the same comment above, so please ignore > that.)
The spec says "Greater than", so I will keep it as it is until there is more clarification about this. When start_extent_id == total_extent_count, return 0 extents. Fan > > Thanks, > Wonjae >