From: Wen Congyang <[email protected]>
Subject: [RFC][PATCH 07/14 v9] target-i386: Add API to write elf notes to core
file
Date: Wed, 14 Mar 2012 10:08:48 +0800
> + descsz = 336; /* sizeof(prstatus_t) is 336 on x86_64 box */
Please introduce prstatus_t for both 32-bit and 64-bit versions. It's
more readable if content of note information is defined as a datatype.
Unecessary memmbers don't need to be defined explicitly. The one in
crash source code is a good example, where only members being used
have meaningful types.
struct elf_prstatus_i386 {
char pad[72];
elf_gregset_i386_t pr_reg; /* GP registers */
__u32 pr_fpvalid; /* True if math co-processor being
used. */
};
> + descsz = 144; /* sizeof(prstatus_t) is 144 on x86 box */
Also.
> + descsz = 144; /* sizeof(prstatus_t) is 144 on x86 box */
Also.
Thanks.
HATAYAMA, Daisuke
