On Mon, 4 Mar 2024 15:23:00 +0100 Igor Mammedov <imamm...@redhat.com> wrote:
> On Mon, 4 Mar 2024 16:25:03 +0530 > Ani Sinha <anisi...@redhat.com> wrote: > > > > On 27-Feb-2024, at 21:17, Igor Mammedov <imamm...@redhat.com> wrote: > > > > > > basically moving code around without functional change. > > > And exposing some symbols so that they could be shared > > > between smbbios.c and new smbios_legacy.c > > > > > > plus some meson magic to build smbios_legacy.c only > > > for 'pc' machine and otherwise replace it with stub > > > if not selected. > > > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > > --- [...] > > > + /* > > > + * preserve blob size for legacy mode so it could build its > > > + * blobs flavor from 'usr_blobs' > > > + */ > > > + smbios_add_usr_blob_size(size); > > > + > > > > Could this have been made as a part of a separate patch? It is extremely > > hard to understand why you are doing this when it’s a part of a larger code > > refactoring/modularisation. > > sure, will do on respin I also has split out variables renaming into a separate patch. Hope it will make it easier to review. > [...]
