On Tue, 9 Apr 2024 at 14:38, Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
>
> rx_status_fifo_size is a word count, rename it to avoid confusion.
>
> Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> ---
> hw/net/lan9118.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c
> index cace22381d..663776f575 100644
> --- a/hw/net/lan9118.c
> +++ b/hw/net/lan9118.c
> @@ -259,7 +259,7 @@ struct lan9118_state {
> int32_t tx_status_fifo_head;
> uint32_t tx_status_fifo[512];
>
> - int32_t rx_status_fifo_size;
> + int32_t rx_status_fifo_wordcount;
> int32_t rx_status_fifo_used;
> int32_t rx_status_fifo_head;
True, but rx_status_fifo_used and rx_status_fifo_head
are also word counts. Should we try to indicate units in
all these names, or is that getting unwieldy?
-- PMM
