Collin Walling <wall...@linux.ibm.com> writes: > On 4/24/24 02:19, Markus Armbruster wrote: >> Collin Walling <wall...@linux.ibm.com> writes: >> >>> This optional parameter for query-cpu-model-expansion enables CPU >>> model features flagged as deprecated to appear in the resulting >>> list of properties. >>> >>> This commit does not add support beyond adding a new argument >>> to the query. All queries with this option present will result >>> in an error claiming this option is not supported. >>> >>> Signed-off-by: Collin Walling <wall...@linux.ibm.com> >>> --- >>> qapi/machine-target.json | 7 ++++++- >>> target/arm/arm-qmp-cmds.c | 7 +++++++ >>> target/i386/cpu-sysemu.c | 7 +++++++ >>> target/s390x/cpu_models_sysemu.c | 7 +++++++ >>> 4 files changed, 27 insertions(+), 1 deletion(-) >>> >>> diff --git a/qapi/machine-target.json b/qapi/machine-target.json >>> index 29e695aa06..b9da284d2d 100644 >>> --- a/qapi/machine-target.json >>> +++ b/qapi/machine-target.json >>> @@ -285,6 +285,10 @@ >>> # >>> # @type: expansion type, specifying how to expand the CPU model >>> # >>> +# @disable-deprecated-feats: include CPU model features that are >>> +# flagged as deprecated. If supported, these features will appear >>> +# in the properties list paired with false. >> >> What's the default? >> >> Which command result(s) does this affect? Suggest to explain using >> unabridged example QMP input and output before and after this series. > > Fair enough. Bool defaults to false but that's not apparent in the > description. I will add more detail.
I didn't mean to ask for example QMP in the doc comment. I need you to explain the new member to me. Once I understand what the thing does, I may have suggestions on improving the doc comment. [...] > Thanks for your feedback! You're welcome!
