Re: [PATCH] ui/console: Only declare variable fence_fd when CONFIG_GBM is defined

[Philippe Mathieu-Daudé]

On 15/5/24 12:05, Cédric Le Goater wrote:

This to avoid a build breakage :

../ui/gtk-egl.c: In function ‘gd_egl_draw’:
../ui/gtk-egl.c:73:9: error: unused variable ‘fence_fd’ 
[-Werror=unused-variable]
    73 |     int fence_fd;
       |         ^~~~~~~~

Fixes: fa6426805b12 ("ui/console: Use qemu_dmabuf_set_..() helpers instead")
Cc: Dongwon Kim <dongwon....@intel.com>
Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
Signed-off-by: Cédric Le Goater <c...@redhat.com>
---
  ui/gtk-egl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 
0473f689c915f8b2303cd9d11bc7d8336c2a85ba..9831c10e1bd58f76d8f803ad0a72d983adc3f490
 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -68,9 +68,9 @@ void gd_egl_draw(VirtualConsole *vc)
      GdkWindow *window;
  #ifdef CONFIG_GBM
      QemuDmaBuf *dmabuf = vc->gfx.guest_fb.dmabuf;
+    int fence_fd;
  #endif
      int ww, wh, ws;
-    int fence_fd;

if (!vc->gfx.gls) {

          return;

Thanks for the quick fix (unfortunately this case isn't
covered on CI).

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>