23.05.2024 04:46, Song Gao wrote:
From: Jiaxun Yang <jiaxun.y...@flygoat.com>Higher bits for memory nodes were omitted at qemu_fdt_setprop_cells. Cc: qemu-sta...@nongnu.org Signed-off-by: Jiaxun Yang <jiaxun.y...@flygoat.com> Reviewed-by: Song Gao <gaos...@loongson.cn> Message-Id: <20240520-loongarch-fdt-memnode-v1-1-5ea9be939...@flygoat.com> Signed-off-by: Song Gao <gaos...@loongson.cn> --- hw/loongarch/virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index e3bdf085b5..3e6e93edf3 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -464,7 +464,8 @@ static void fdt_add_memory_node(MachineState *ms, char *nodename = g_strdup_printf("/memory@%" PRIx64, base);qemu_fdt_add_subnode(ms->fdt, nodename);- qemu_fdt_setprop_cells(ms->fdt, nodename, "reg", 0, base, 0, size); + qemu_fdt_setprop_cells(ms->fdt, nodename, "reg", base >> 32, base, + size >> 32, size); qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "memory");if (ms->numa_state && ms->numa_state->num_nodes) {
This commit changes exactly the same place as the previous commit, v9.0.0-274-gb11f981452, "hw/loongarch: Fix fdt memory node wrong 'reg'". Was it the wrong fix? Note the previous commit isn't in any released version of qemu. So when picking up for any stable release, both needs to be picked up :) Thanks, /mjt -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5 Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
