On Thu, 6 Jun 2024 at 10:24, Paolo Bonzini <pbonz...@redhat.com> wrote: > Queued, thanks.
Thanks - also for reviewing, etc.! > Thanks for persisting! It sucks that the hv_vcpu_interrupt() API docs > are not clear, but your tests are great. The self-interrupt one is > the case that I was most worried about, and you're covering it. > Sorry for being a pain for nothing, at least retrospectively. No worries - the concern is understandable, especially in the face of the unfortunate apparent regression which turned out to be the dirty page tracking bug. And I agree, the hv_vcpu_interrupt docs, along with the rest of Hypervisor.framework's, are terrible. There does not appear to have been any thought about what a developer using that API might care about. I've been working on integrating the HVF APIC/PIC/IOAPIC implementations, and there are ambiguities and edge cases galore. Unfortunately (?), the perf improvement is worth the trouble of trial & error… Phil
