@@ -75,6 +75,7 @@ struct AspeedGPIOClass {
uint32_t nr_gpio_pins;
uint32_t nr_gpio_sets;
const AspeedGPIOReg *reg_table;
+ uint32_t reg_table_size;
};
- "reg_table_size" is a number of registers, using s/size/count/ might
be clearer.
- No point in specifying 32-bit, "unsigned" is sufficient.
(Cédric, if you agree, you might update your tree).
Unrelated to this patch but figured out while reviewing, in
aspeed_gpio_read/write 'idx' is
- pointlessly assigned to -1
- of type 'uint64_t', also pointless, 'unsigned' is clearer.
Zheyu, could you please send a v4 ? Thanks,
C.