> 4 июля 2024 г., в 10:38, Michael S. Tsirkin <m...@redhat.com> написал(а): > > On Thu, Jul 04, 2024 at 10:25:53AM +0300, Mikhail Krasheninnikov wrote: >> >> On Wed, 3 Jul 2024, Michael S. Tsirkin wrote: >> >>> On Wed, Jul 03, 2024 at 10:55:17PM +0300, Mikhail Krasheninnikov wrote: >>>> >>>> Hello, Alex! >>>> >>>> No, there's no patch to the VirtIO specification yet. This is >>>> proof-of-concept solution since I'm not sure that I did everything >>>> correct with the design (and as folks' reviews show, for a good reason). >>>> As soon as most obvious issues would be out of the way, I think I'll >>>> submit a patch. >>> >>> >>> Mikhail, if you want people to review your patches but not merge >>> them yet, pls use an RFC tag in the subject to avoid confusion. >>> >>> Thanks, >>> >>> -- >>> MST >>> >>> >> >> Hello, Michael! >> >> I was planning to submit three patches: to the kernel, emulator and Virtio >> specification around the same time - as soon as the obvious bugs are >> fixed, I'll submit a patch to the specification. I thought it wasn't >> necessary to use the RFC tag in that case, but if you think it is, >> I'll include it with the next version of the patch. > > RFC means "this is proof of concept". On the one hand some people > won't bother reviewing then. On the other your patch will be > judged less harshly. If your code still has debugging printks, > it's clearly an RFC at best. > > -- > MST >
I apologize for the debug printks in other patch, I’m not really sure how I gazed over it.. If it makes my situation better, it’s my first series of patches. I’ll make sure to triple-check next time. Thanks for the feedback!
