On Fri, Jul 12, 2024 at 12:31 AM Daniel P. Berrangé <berra...@redhat.com> > wrote:
On Thu, Jul 11, 2024 at 04:53:50PM +0900, Akihiko Odaki wrote: > > On 2024/07/10 17:02, hellord wrote: > > > > > > note: > > > 1. The path of buggy msvcrt.dll is c:\windows\system32\msvcrt.dll( > > > mingw64 links to it ); > > > 2. fwrite implementation in another msvc library which is called > > > ucrtbase.dll is correct(msvc links to it by default). > > > > I don't object to this change but you should use ucrt whenever possible. > I'm > > not confident that elf2dmp and other QEMU binaries would work well with > > mvcrt. > > > > I even would like to force users to use ucrt and call setlocale(LC_ALL, > > ".UTF8") to fix text encoding, but I haven't done that yet because > Fedora, > > which cross-compiles QEMU for CI, still uses msvcrt. > > Our native Windows builds are also validating with msvcrt, and Stefan's > Windows packages for QEMU are also msvcrt. > > Users getting QEMU packages from msys can choose whether to pull the > msvcrt build or the ucrt build, but forcing ucrt is a non-starter IMHO. > > I will also submit a ticket to Microsoft to report this bug next week. I believe they should fix it, as this file is distributed along with the operating system, and many of the OS's own components are also linked to it.
