On Thu, 2024-08-01 at 05:48 -0400, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2024 at 09:49:06AM +0100, David Woodhouse wrote: > > On Wed, 2024-07-31 at 17:19 -0400, Michael S. Tsirkin wrote: > > > > > > > Perfect. So as and when the header is in its final form in Linux, > > > > it can be part of the automated import and we'll use that version. > > > > At that point we can drop the one that's sitting alongside the > > > > device itself in hw/acpi/. > > > > > > Yes. Maybe add a comment in the temporary header. > > > > I pondered that, but kind of preferred to have it byte-identical. > > > > Admittedly I'm not *planning* to have to change it any more but it's > > been useful so far that I can just *copy* the file between the Linux > > and Linux-backport and QEMU repositories. > > ok. note machinery we have is clever, it handles __le and such stuff > automatically.
Sure. But the *temporary* file in hw/acpi isn't using that machinery; it's literally just copied. I can add a comment in the vmclock.c file where we *include* it, noting that it's sitting here in the same directory for now, but in the fullness of time it will be imported from Linux. --- a/hw/acpi/vmclock.c +++ b/hw/acpi/vmclock.c @@ -22,6 +22,7 @@ #include "migration/vmstate.h" #include "sysemu/reset.h" +/* This will come from Linux headers in the end, but we carry our own for now. */ #include "vmclock-abi.h" void vmclock_build_acpi(VmclockState *vms, GArray *table_data,
smime.p7s
Description: S/MIME cryptographic signature
