On Wed, Aug 07, 2024 at 07:51:10PM +0000, Alejandro Zeise wrote: > Implements the new hashing API in the gcrypt hash driver. > Supports creating/destroying a context, updating the context > with input data and obtaining an output hash. > > Signed-off-by: Alejandro Zeise <alejandro.ze...@seagate.com> > --- > crypto/hash-gcrypt.c | 79 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/crypto/hash-gcrypt.c b/crypto/hash-gcrypt.c > index 829e48258d..e05511cafa 100644 > --- a/crypto/hash-gcrypt.c > +++ b/crypto/hash-gcrypt.c > @@ -1,6 +1,7 @@ > /* > * QEMU Crypto hash algorithms > * > + * Copyright (c) 2024 Seagate Technology LLC and/or its Affiliates > * Copyright (c) 2016 Red Hat, Inc. > * > * This library is free software; you can redistribute it and/or > @@ -110,7 +111,85 @@ qcrypto_gcrypt_hash_bytesv(QCryptoHashAlgorithm alg, > return -1; > } > > +static > +QCryptoHash *qcrypto_gcrypt_hash_new(QCryptoHashAlgorithm alg, Error **errp) > +{ > + QCryptoHash *hash = NULL; > + > + if (!qcrypto_hash_supports(alg)) { > + error_setg(errp, > + "Unknown hash algorithm %d", > + alg); > + } else { > + hash = g_new(QCryptoHash, 1); > + hash->alg = alg; > + hash->opaque = g_new(gcry_md_hd_t, 1); > + > + gcry_md_open((gcry_md_hd_t *) hash->opaque, > qcrypto_hash_alg_map[alg], 0);
Need to check for error from gcry_md_open and report it, and free hash & hash->opaque > + } > + > + return hash; > +} With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|