Re: [PATCH-for-9.1 v3 1/2] target/mips: Pass page table entry size as MemOp to get_pte()

[Richard Henderson]

On 8/13/24 23:53, Philippe Mathieu-Daudé wrote:

@@ -607,11 +607,11 @@ static bool get_pte(CPUMIPSState *env, uint64_t vaddr, 
int entry_size,
  }

static uint64_t get_tlb_entry_layout(CPUMIPSState *env, uint64_t entry,

-        int entry_size, int ptei)
+                                     MemOp op, int ptei)
  {
      uint64_t result = entry;
      uint64_t rixi;
-    if (ptei > entry_size) {
+    if (ptei > memop_size(op)) {

entry_size had been 32/64, now you're comparing against 4/8.


Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~