On 9/10/24 11:33, Akihiko Odaki wrote:
On 2024/09/10 18:21, Michael S. Tsirkin wrote:
On Fri, Aug 23, 2024 at 02:00:37PM +0900, Akihiko Odaki wrote:
Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com>
("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")
I submitted a RFC series[1] to add support for SR-IOV emulation to
virtio-net-pci. During the development of the series, I fixed some
trivial bugs and made improvements that I think are independently
useful. This series extracts those fixes and improvements from the RFC
series.
[1]: https://patchew.org/QEMU/20231210-sriov-v2-0-b959e8a6d...@daynix.com/
Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
I don't think Cédric's issues have been addressed, am I wrong?
Cédric, what is your take?
I put the URI to Cédric's report here:
https://lore.kernel.org/r/75cbc7d9-b48e-4235-85cf-49dacf3c7...@redhat.com
This issue was dealt with patch "s390x/pci: Check for multifunction after device
realization". I found that s390x on QEMU does not support multifunction and SR-IOV
devices accidentally circumvent this restriction, which means igb was never supposed to
work with s390x. The patch prevents adding SR-IOV devices to s390x to ensure the
restriction is properly enforced.
yes, indeed and it seems to fix :
6069bcdeacee ("s390x/pci: Move some hotplug checks to the pre_plug handler")
I will update patch 4.
Thanks,
C.
That said, the igb device worked perfectly fine under the s390x machine.
