On Tue, Sep 10, 2024 at 04:16:23PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > (This is commit 663df1cc68). > > On 27/9/22 10:19, Gerd Hoffmann wrote: > > From: Alexandre Ratchov <a...@caoua.org> > > > > sndio is the native API used by OpenBSD, although it has been ported to > > other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). > > > > Signed-off-by: Brad Smith <b...@comstyle.com> > > Signed-off-by: Alexandre Ratchov <a...@caoua.org> > > Reviewed-by: Volker Rümelin <vr_q...@t-online.de> > > Tested-by: Volker Rümelin <vr_q...@t-online.de> > > Message-Id: <yxibxrwsrs3xy...@vm1.arverb.com> > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > > --- > > meson_options.txt | 4 +- > > audio/audio_template.h | 2 + > > audio/audio.c | 1 + > > audio/sndioaudio.c | 565 ++++++++++++++++++++++++++++++++++ > > MAINTAINERS | 7 + > > audio/meson.build | 1 + > > meson.build | 9 +- > > qapi/audio.json | 25 +- > > qemu-options.hx | 16 + > > scripts/meson-buildoptions.sh | 7 +- > > 10 files changed, 632 insertions(+), 5 deletions(-) > > create mode 100644 audio/sndioaudio.c > > > > diff --git a/audio/sndioaudio.c b/audio/sndioaudio.c > > new file mode 100644 > > index 000000000000..7c45276d36ce > > --- /dev/null > > +++ b/audio/sndioaudio.c > > @@ -0,0 +1,565 @@ > > +/* > > + * SPDX-License-Identifier: ISC > > This is the single use of the ISC license in the more than 10k > files in the repository. Just checking IIUC this document: > https://www.gnu.org/licenses/quick-guide-gplv3.en.html > > ISC -> LGPLv2.1 -> GPLv2 -> GPLv3 > > So ISC is compatible with GPLv2-or-later. Is that correct?
ISC is a permissive license that's semantically pretty much equivalent to either MIT or BSD 2 clause licenses and thus is broadly compatible with most other licenses, including the various GPL variants/versions. None the less, since sndioaudio.c was a new file, it should have been submitted using the GPLv2+, unless there was a reason it needed to diverge and use ISC. An example justification for divering is if the new code is derived from some non-QEMU source that was already ISC. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
