On Mon, Sep 16, 2024 at 7:57 PM Stefan Hajnoczi <stefa...@redhat.com> wrote:
> This patch series could use tests. The first two patches seem broken and > testing would have revealed that the memory allocation and pointers are > not quite right. > My bad. Previous version of the patch I did test with a device that I've been working on that utilizes the map/unmap messages. But I skipped it for this one. I will test it for any coming versions. > > One testing approach is to write a test device using libvhost-user that > exposes VIRTIO Shared Memory Regions, launch QEMU in qtest mode with > --device vhost-user-device, and then use the qtest API to enumerate and > access the VIRTIO Shared Memory Regions. Unfortunately this involves > writing quite a bit of test code. I can explain it in more detail if you > want. > If we want to have tests covering the feature within qemu, I can try to do this. I'm also more comfortable if there are tests in place. As I mentioned, before this patch I was verifying with an external device myself. > > Does anyone have other ideas for testing? > > Stefan >
