On Mon, Oct 7, 2024 at 1:11 PM Daniel P. Berrangé <berra...@redhat.com> wrote: > The current dockerfiles don't include rust, and I see nothing > here updating them to add rust, so how is any of this getting > test coverage ? > > Even though this has Rust disabled by default, I would still > consider CI enablement to be a pre-requsite for merging even > basic Rust support.
I agree in general, but there's already a lot of work that can be parallelized and the idea of someone managing Rust-related patches out-of-tree was discarded. So this seemed to be the only way to proceed. Right now only Fedora 39 and 40 (with updates) are able to compile QEMU with Rust enabled. Full CI enablement requires further work to reduce the minimum supported version of the compiler, after which rustc can be added to the libvirt-ci inputs and to the Dockerfiles. Adding a CI job that uses nightly rust (via rustup) is high on my priority list, but first of all I wanted to integrate clippy (because the main point of having a job with nightly rust is to have a heads-up on future clippy warnings). That said, I'm also not sure how one would go adding rustup to a container generated by lcitool (for example should I add a new dockerfile that is _based_ on one that already exists? would that change when Rust/rustc is added to that dockerfile?). I think the best thing to do is to do a presentation to the whole community, maybe next week, explaining the state of the experiment and asking for help. Paolo