On Thu, Oct 10, 2024 at 04:56:28PM +0200, Markus Armbruster wrote: > The error message for a "stepping" value that is out of bounds is a > bit odd: > > $ qemu-system-x86_64 -cpu qemu64,stepping=16 > qemu-system-x86_64: can't apply global qemu64-x86_64-cpu.stepping=16: > Property .stepping doesn't take value 16 (minimum: 0, maximum: 15) > > The "can't apply global" part is an unfortunate artifact of -cpu's > implementation. Left for another day. > > The remainder feels overly verbose. Change it to > > qemu64-x86_64-cpu: can't apply global qemu64-x86_64-cpu.stepping=16: > parameter 'stepping' can be at most 15 > > Likewise for "family", "model", and "tsc-frequency". > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > target/i386/cpu.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
