On Wed, 27 Mar 2024 at 01:50, Akihiko Odaki <akihiko.od...@daynix.com> wrote: > > The arguments in MESONINTROSPECT are quoted with shlex.quote() so it > must be parsed with shlex.split(). > > Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> > > To: Beraldo Leal <bl...@redhat.com> > To: Peter Maydell <peter.mayd...@linaro.org> > Cc: qemu-devel@nongnu.org > Cc: Philippe Mathieu-Daudé <phi...@linaro.org> > Cc: Thomas Huth <th...@redhat.com> > Cc: Daniel P. Berrangé <berra...@redhat.com> > Cc: Marc-André Lureau <marcandre.lur...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: Cleber Rosa <cr...@redhat.com> > Cc: John Snow <js...@redhat.com> > Cc: Michael Tokarev <m...@tls.msk.ru> > > Changes in v3: > - Ensured meson>=1.4.0 on Windows. > - Link to v2: > https://lore.kernel.org/r/20240326-meson-v2-0-d9f900377...@daynix.com > > Changes in v2: > - Added patch "buildsys: Bump known good meson version to v1.4.0". > - Link to v1: > https://lore.kernel.org/r/20230812061540.5398-1-akihiko.od...@daynix.com > > --- > Akihiko Odaki (2): > buildsys: Bump known good meson version to v1.4.0 > meson: Fix MESONINTROSPECT parsing > > configure | 5 +++++ > python/scripts/vendor.py | 4 ++-- > python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes > python/wheels/meson-1.4.0-py3-none-any.whl | Bin 0 -> 935471 bytes > pythondeps.toml | 2 +- > scripts/symlink-install-tree.py | 3 ++- > 6 files changed, 10 insertions(+), 4 deletions(-)
I've just had a report of somebody running into this "if you have a ~ in your build dir then symlink-install-tree breaks" bug, and realized we never applied this series. We've just required rust 1.5.0 (commit 07f0d32641e0) because we need it for the Rust support, so we don't need patch 1 here any more or the windows-specific bits in patch 2. So I think we can just update the symlink-install-tree script now, which ironically is what v1 of this patchset did :-) (Though if we cared about fixing this in the stable branches that would be more awkward.) -- PMM
