On Tue, 29 Oct 2024 at 20:47, <castet.matth...@free.fr> wrote: > >Our coding style for multiline comments says > >/* > > * they look like this, with the opening and closing markers on > > * lines of their own > > */ > > I will changed that. > > It do not seem to be followed in In hw/intc/armv7m_nvic.c, but my new comment > should also follow > this rule in this file ?
Yes, please. We have quite a lot of older code that was written before we imposed some of the coding style standardisations we now use, so you'll see stuff that doesn't quite follow the rules in files already. Our general policy is that we don't bother to try to tidy up pre-existing code, but where we're adding new code or if we have to touch the code for some other reason we'll clean it up in that local area. (A rough guide is "if the checkpatch script complains about it consider fixing it", though checkpatch is not always correct about its suggestions.) thanks -- PMM
