Hi Roque,
On 1/11/24 18:41, Roque Arcudia Hernandez wrote:
This contains a series of small compiler fixes to enable the compilation
of qemu using clang-cl.
It mainly involves adding some missing header files and updating #ifdefs
to handle clang-cl specific things.
Signed-off-by: Erwin Jansen <jans...@google.com>
Signed-off-by: Roque Arcudia Hernandez <roq...@google.com>
---
include/qemu/compiler.h | 3 ++-
include/sysemu/dma.h | 2 ++
include/sysemu/os-win32.h | 2 +-
migration/savevm.c | 2 ++
tests/qtest/libqtest.c | 2 +-
5 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h
index 5a49a30628..f53b751fe2 100644
--- a/include/sysemu/dma.h
+++ b/include/sysemu/dma.h
@@ -14,6 +14,8 @@
#include "exec/address-spaces.h"
#include "block/block.h"
#include "block/accounting.h"
+#include "block/aio.h"
+#include "qemu/iov.h"
This change, ...
typedef enum {
DMA_DIRECTION_TO_DEVICE = 0,
diff --git a/migration/savevm.c b/migration/savevm.c
index 7e1e27182a..c082015e84 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -54,6 +54,8 @@
#include "qemu/job.h"
#include "qemu/main-loop.h"
#include "block/snapshot.h"
+#include "block/block-io.h"
+#include "block/block-global-state.h"
... and this one look sane. But please commit them separately
(preferably justifying what declarations are missing), not hidden
behind "sysemu/os-win32.h" subject.
#include "qemu/cutils.h"
#include "io/channel-buffer.h"
#include "io/channel-file.h"
Could you post a series (including this patch) ending with a
patch exercising clang-cl in a job on our CI?
Thanks,
Phil.
