Daniel P. Berrangé <berra...@redhat.com> writes: > On Tue, Nov 05, 2024 at 03:08:21PM -0300, Fabiano Rosas wrote: >> We current have a bunch of non-test functions in migration-test.c and >> some others in migration-helpers.c. In order to split migration-test.c >> into separate test binaries, these helpers need to go somewhere >> else. >> >> To avoid making migration-helpers even larger, move all QMP-related >> functions into a new migration-qmp.c file and put it under the >> qtest/migration/ directory. >> >> The new file holds everything that has as its main responsibility to >> call into QMP. >> >> Signed-off-by: Fabiano Rosas <faro...@suse.de> >> --- >> tests/qtest/meson.build | 1 + >> tests/qtest/migration-helpers.c | 250 +------------ >> tests/qtest/migration-helpers.h | 18 +- >> tests/qtest/migration-test.c | 237 +----------- >> tests/qtest/migration/migration-qmp.c | 485 +++++++++++++++++++++++++ >> tests/qtest/migration/migration-util.h | 45 +++ > > I would have expected the header to be named 'migration-qmp.h' to match > the source file naming, and not merge all of migration-helpers.h into > it in the next patch which seems to partially defeat the point of splitting > up the files. >
Ok, I can change that.
