On Wed, Nov 06, 2024 at 09:40:21AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé <berra...@redhat.com> writes: > > > On Tue, Nov 05, 2024 at 03:08:36PM -0300, Fabiano Rosas wrote: > >> Allow qtests to be ran by subsystem. Some subsystems, such as > >> migration, have a large number of tests and we could benefit from > >> being able to access them from make check without having to run the > >> full set of qtests. > >> > >> This adds the following make check targets: > >> > >> make check-qtest-migration > >> > >> Signed-off-by: Fabiano Rosas <faro...@suse.de> > >> --- > >> I did not include check-qtest-<arch>-<subsys> because meson generates a > >> long line that affects readability. > > > > Can you give an example of that ? I'm wondering how much of a > > problem it actually is ? Personally when I'm running a subset > > of tests, I almost always want to limit to just one arch target. > > > > Ok, you have a different use case, mine is just "run migration tests for > all archs, without bringing all the rest of qtest along". When I want to > limit to one arch, I use the 'QTEST_QEMU_BINARY=qemu-system-<arch> > migration-test' syntax. > > The issue is that meson always shows all suites in which a test is > present (quite uselessly IMO):
Ewwww, yes, that's pretty horrific :-( Very annoying behaviour, as it actively discourages people from adding more suites :-( I agree with your decision. > > [1-8/8] 🌑 qemu:qtest+qtest-s390x+qtest-migration+qtest-s390x-migration / > qtest-s390x/migration-test 0/480 > 1/8 qemu:qtest+qtest-x86_64+qtest-migration+qtest-x86_64-migration / > qtest-x86_64/migration-test-smoke SKIP 0.02s > > vs: > > 1/8 qemu:qtest+qtest-x86_64+qtest-migration / > qtest-x86_64/migration-test-smoke SKIP 0.02s > 2/8 qemu:qtest+qtest-ppc64+qtest-migration / qtest-ppc64/migration-test > SKIP 0.02s > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
