Daniel P. Berrangé <berra...@redhat.com> writes: > On Mon, Nov 04, 2024 at 09:09:40AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé <berra...@redhat.com> writes: >> >> > The 'loaded' property on TLS creds and secret objects was marked as >> > deprected in 6.0.0 and then marked as removed in 7.1.0. >> >> deprecated >> >> Regarding "marked as removed": not quite. Its entry was moved from >> docs/about/deprecated.rst to docs/about/removed-features.rst, but the >> text there is "should simply be removed." >> >> > >> > Except it wasn't actually removed, it was just made read-only, while >> > claiming it was removed. Finish the long overdue removal job. >> > >> > Fixes: 0310641c06dd5f7ea031b2b6170cb2edc63e4cea >> >> I'm not sure it fixes something that was broken. Commit 0310641c06d >> (crypto: make loaded property read-only) did what it said on the tin. >> What it did was unusual, and maybe a bad idea. > > I'm re-wording the commit message to: > > The 'loaded' property on TLS creds and secret objects was marked as > deprecated in 6.0.0. In 7.1.0 the deprecation info was moved into > the 'removed-features.rst' file, but the property was not actually > removed, just made read-only. This was a highly unusual practice, > so finish the long overdue removal job. > > and removing the "Fixes" tag
Thanks! [...]
