On 14/11/2024 02.12, Philippe Mathieu-Daudé wrote:
"exec/cpu-defs.h" should be kept as minimal as possible;
besides these includes don't seem necessay. Remove them.
s/necessay/necessary/
diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -23,14 +23,6 @@
#error cpu.h included from common code
#endif
-#include "qemu/host-utils.h"
-#include "qemu/thread.h"
-#ifndef CONFIG_USER_ONLY
-#include "exec/hwaddr.h"
-#endif
-#include "exec/memattrs.h"
-#include "hw/core/cpu.h"
Seems to work. Good catch!
Tested-by: Thomas Huth <th...@redhat.com>