On 11/12/24 02:00, Alex Bennée wrote: > There are two identical sequences of a code doing the same thing that > raise warnings with Coverity. Before fixing those issues lets factor > out the common code into a helper function we can share. > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > Cc: Dmitry Osipenko <dmitry.osipe...@collabora.com> > > --- > v2 > - fix compile of virtio-gpu-virgl > - tweak comment for blob_size > --- > include/hw/virtio/virtio-gpu.h | 15 +++++++++ > hw/display/virtio-gpu-virgl.c | 22 +------------ > hw/display/virtio-gpu.c | 60 +++++++++++++++++++++------------- > 3 files changed, 53 insertions(+), 44 deletions(-)
... > + return true; > +} > + > + > + > static void virtio_gpu_set_scanout_blob(VirtIOGPU *g, Super-nit: the extra newlines are still there. You may edit them when applying, otherwise we can live with them for now too :) Thanks for addressing rest of the v1 comments! Reviewed-by: Dmitry Osipenko <dmitry.osipe...@collabora.com> Tested-by: Dmitry Osipenko <dmitry.osipe...@collabora.com> -- Best regards, Dmitry
