Thanks everyone for your valuable feedback on this, and taking time to
give more rationale about the previous position you had.
On 11/25/24 03:19, Thomas Huth wrote:
So fine for me if we allow compiling with Clang on Windows now, but we
should make sure to avoid that those problems are sneaking in again. So
Pierrick, please provide a patch to docs/devel/style.rst to say that we
disallow bitfields in packed structs in future contributions. Then I think
it's ok to remove the gcc_struct from QEMU_PACKED. (Just my 2 cents, of course)
Thomas
I just compared windows binaries with/without gcc_struct, and as Thomas
found for qemu linux binaries using pahole, there is no difference with
or without gcc_struct, so the attribute is unused now.
In case you want to check that by yourself, I uploaded binaries and
dwarf info on this repo:
https://github.com/pbo-linaro/qemu_packed_structs
(gcc_attribute has gcc_struct binaries, gcc_no_attribute_no_option has
binaries without it).
Before sending the a series removing gcc_struct and editing the
documentation, do we all agree here it's the right move forward?
If yes, should we apply this to 9.2 release?
Thanks,
Pierrick
