On Thu, Nov 28, 2024 at 01:12:01PM +0100, Maciej S. Szmigiero wrote: > On 28.11.2024 11:33, Avihai Horon wrote: > > > > On 17/11/2024 21:20, Maciej S. Szmigiero wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > From: "Maciej S. Szmigiero" <maciej.szmigi...@oracle.com> > > > > > > Since device state transfer via multifd channels requires multifd > > > channels with packets and is currently not compatible with multifd > > > compression add an appropriate query function so device can learn > > > whether it can actually make use of it. > > > > > > Signed-off-by: Maciej S. Szmigiero <maciej.szmigi...@oracle.com> > > > --- > > > include/migration/misc.h | 1 + > > > migration/multifd-device-state.c | 7 +++++++ > > > 2 files changed, 8 insertions(+) > > > > > > diff --git a/include/migration/misc.h b/include/migration/misc.h > > > index 118e205bbcc6..43558d9198f7 100644 > > > --- a/include/migration/misc.h > > > +++ b/include/migration/misc.h > > > @@ -112,5 +112,6 @@ bool migration_in_bg_snapshot(void); > > > /* migration/multifd-device-state.c */ > > > bool multifd_queue_device_state(char *idstr, uint32_t instance_id, > > > char *data, size_t len); > > > +bool migration_has_device_state_support(void); > > > > Nit: maybe rename to multifd_device_state_supported or > > migration_multifd_device_state_supported, as it's specifically related to > > multifd? > > Sure, will do.
With that, feel free to take: Reviewed-by: Peter Xu <pet...@redhat.com> -- Peter Xu
