On Thu, Jan 02, 2025 at 01:35:22PM -0500, Steven Sistare wrote:
> > > > + MigrateCommon args = {
> > > > + .start.opts_source = opts,
> > > > + .start.opts_target = opts_target,
> > > > + .start.defer_target_connect = true,
> >
> > One more comment: maybe we can even drop defer_target_connect. I don't
> > expect any non-cpr test to use it.. so introducing the parameter may only
> > complicate MigrateCommon struct with almost zero benefit to be reused.
> >
> > If to drop it, we could detect "cpr" channel in test_precopy_common() and
> > only defer the connection if "cpr" channel is present.
>
> I hear you regarding lack of reuse, but I still think defining this single
> field is the cleanest solution. It is tested in multiple places, in different
> functions, so the search for cpr channel code would also be needed in multiple
> places.
OK, let's keep it.
--
Peter Xu
